[builtins] Remove superfluous fixed array allocation

[builtins] Remove superfluous fixed array allocation

Speeds up Object.keys by another ~10-20% :)

Committed: https://crrev.com/eb6d46de9f5ecf7dc5f75fd8c35e482755968c91
Cr-Commit-Position: refs/heads/master@{#33945}

[Toon Verwaest, 2016-02-12 12:51:49]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2016-02-12 12:52:04]

verwaest@chromium.org changed reviewers:
+ cbruni@chromium.org

[Toon Verwaest, 2016-02-12 12:52:04]

ptal

[Camillo Bruni, 2016-02-12 13:04:21]

lgtm

https://codereview.chromium.org/1697533002/diff/20001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1697533002/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:1857: isolate->heap()->empty_fixed_array()) {
Maybe add a HasNoElements helper at some point?

https://codereview.chromium.org/1697533002/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:1868: keys = isolate->factory()->CopyFixedArrayUpTo(cache,
enum_length);
This pattern probably as well... GetEnumCacheCopy ;)

[Toon Verwaest, 2016-02-12 13:13:12]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-02-12 13:13:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697533002/20001

[commit-bot: I haz the power, 2016-02-12 13:42:50]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-02-12 13:43:34]

Description was changed from

==========
[builtins] Remove superfluous fixed array allocation

Speeds up Object.keys by another ~10-20% :)
==========

to

==========
[builtins] Remove superfluous fixed array allocation

Speeds up Object.keys by another ~10-20% :)

Committed: https://crrev.com/eb6d46de9f5ecf7dc5f75fd8c35e482755968c91
Cr-Commit-Position: refs/heads/master@{#33945}
==========

[commit-bot: I haz the power, 2016-02-12 13:43:34]

Patchset 1 (id:??) landed as
https://crrev.com/eb6d46de9f5ecf7dc5f75fd8c35e482755968c91
Cr-Commit-Position: refs/heads/master@{#33945}