Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3501)

Unified Diff: runtime/bin/bin.gypi

Issue 169753003: Don't depend on libdart_io in run_vm_tests and gen_snapshot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make run_vm_tests pass again. Note sure about run_vm_tests.host. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/builtin_impl_sources.gypi » ('j') | runtime/bin/builtin_no_io.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/bin.gypi
diff --git a/runtime/bin/bin.gypi b/runtime/bin/bin.gypi
index 2a0b6be65a4e08cb58b9d8051a0588ee8e390557..19b89f55fb6dc2d0238d4af605f19af30010c323 100644
--- a/runtime/bin/bin.gypi
+++ b/runtime/bin/bin.gypi
@@ -168,9 +168,29 @@
],
},
{
+ 'target_name': 'libdart_builtin_no_io',
Ivan Posva 2014/02/25 07:53:12 I am a bit puzzled by this new target as it does n
Anders Johnsen 2014/02/25 08:31:32 Yeah, you are 100% right. This was a solution to a
+ 'type': 'static_library',
+ 'toolsets':['target','host'],
+ 'include_dirs': [
+ '..',
+ ],
+ 'sources': [
+ 'builtin_no_io.cc',
+ ],
+ 'conditions': [
+ ['OS=="linux"', {
+ 'link_settings': {
+ 'libraries': [
+ '-ldl',
+ ],
+ },
+ }],
+ ],
+ },
+ {
'target_name': 'libdart_io',
'type': 'static_library',
- 'toolsets':['target', 'host'],
+ 'toolsets':['target'],
'include_dirs': [
'..',
],
@@ -256,7 +276,6 @@
'dependencies': [
'libdart_withcore',
'libdart_builtin',
- 'libdart_io',
],
'include_dirs': [
'..',
@@ -548,7 +567,6 @@
'dependencies': [
'libdart_withcore',
'libdart_builtin',
- 'libdart_io',
'generate_snapshot_file#host',
'generate_snapshot_test_dat_file#host',
],
« no previous file with comments | « no previous file | runtime/bin/builtin_impl_sources.gypi » ('j') | runtime/bin/builtin_no_io.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698