Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1697523002: Allow immediate tasks to run even when virtual time can't advance (Closed)

Created:
4 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow immediate tasks to run even when virtual time can't advance The main point of preventing virtual time from advancing is to save CPU by avoiding running timers when we don't need to. We still however need immediate tasks to run so that the page load can progress. BUG=546953 Committed: https://crrev.com/f4b5d32e3bb996b3e65e909f2b6bd9ff5a41127a Cr-Commit-Position: refs/heads/master@{#375166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -38 lines) Patch
M components/scheduler/renderer/web_frame_scheduler_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/renderer/web_frame_scheduler_impl.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl_unittest.cc View 3 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697523002/1
4 years, 10 months ago (2016-02-12 11:37:05 UTC) #2
alex clarke (OOO till 29th)
PTAL
4 years, 10 months ago (2016-02-12 11:37:21 UTC) #4
Sami
lgtm. By the way is there any problem here with interval timers that are delayed ...
4 years, 10 months ago (2016-02-12 12:06:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697523002/1
4 years, 10 months ago (2016-02-12 12:24:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 12:42:56 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4b5d32e3bb996b3e65e909f2b6bd9ff5a41127a
Cr-Commit-Position: refs/heads/master@{#375166}

Powered by Google App Engine
This is Rietveld 408576698