Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1697513003: [turbofan] Specialize loads of the native context. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Specialize loads of the native context. When we specialize to the native context, we can replace loads of the NATIVE_CONTEXT_INDEX in any known context with the appropriate native context for that context. This allows us to constant-fold and further optimize things like %reflect_construct, which are inserted by the parser. R=jarin@chromium.org Committed: https://crrev.com/d0c503667e0fdb405e82739ece39eb19a340679d Cr-Commit-Position: refs/heads/master@{#33965}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/compiler/js-native-context-specialization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/compiler/node-properties.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-12 14:36:48 UTC) #1
Jarin
lgtm https://codereview.chromium.org/1697513003/diff/1/src/compiler/node-properties.cc File src/compiler/node-properties.cc (right): https://codereview.chromium.org/1697513003/diff/1/src/compiler/node-properties.cc#newcode344 src/compiler/node-properties.cc:344: // FALL-THROUGH Nit: would it be really so ...
4 years, 10 months ago (2016-02-13 19:31:24 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/1697513003/diff/1/src/compiler/node-properties.cc File src/compiler/node-properties.cc (right): https://codereview.chromium.org/1697513003/diff/1/src/compiler/node-properties.cc#newcode344 src/compiler/node-properties.cc:344: // FALL-THROUGH Hah! But..but..dont-repeat-yourself... :-P
4 years, 10 months ago (2016-02-14 10:19:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697513003/20001
4 years, 10 months ago (2016-02-14 10:19:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-14 10:42:34 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-14 10:43:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0c503667e0fdb405e82739ece39eb19a340679d
Cr-Commit-Position: refs/heads/master@{#33965}

Powered by Google App Engine
This is Rietveld 408576698