Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issue 1697503002: [turbofan] Remove support for LazyBailout operators. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_trycatch-test-enable
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove support for LazyBailout operators. The LazyBailout operator (modelled as a nop-call) was introduced for placing a deoptimization point into exception handlers. Now that we are no longer re-entering lazy deoptimized code, the support can be removed. R=jarin@chromium.org BUG=v8:4195 LOG=n Committed: https://crrev.com/aa31ff31a8851c7c514ab430df6e15981ed269a5 Cr-Commit-Position: refs/heads/master@{#34020}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -128 lines) Patch
M src/ast/ast.h View 1 chunk +1 line, -16 lines 0 comments Download
M src/ast/ast-numbering.cc View 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler/linkage.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 2 chunks +0 lines, -28 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Michael Starzinger
Because less code is better code.
4 years, 10 months ago (2016-02-12 10:24:41 UTC) #1
Benedikt Meurer
Awesome, LGTM!
4 years, 10 months ago (2016-02-12 10:25:32 UTC) #3
Jarin
lgtm
4 years, 10 months ago (2016-02-12 13:23:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697503002/1
4 years, 10 months ago (2016-02-12 13:25:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/2836)
4 years, 10 months ago (2016-02-12 13:27:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697503002/20001
4 years, 10 months ago (2016-02-12 14:34:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10893)
4 years, 10 months ago (2016-02-12 15:23:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697503002/40001
4 years, 10 months ago (2016-02-16 09:40:06 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-16 09:48:21 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 09:49:07 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aa31ff31a8851c7c514ab430df6e15981ed269a5
Cr-Commit-Position: refs/heads/master@{#34020}

Powered by Google App Engine
This is Rietveld 408576698