Run shim's watchForTag on document.DOMContentLoaded

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Shim that simulates a <webview> tag via Mutation Observers.
 //
 // The actual tag is implemented via the browser plugin. The internals of this
 // are hidden via Shadow DOM.
 
+var appWindowNatives = requireNative('app_window_natives');
 var forEach = require('utils').forEach;
 var watchForTag = require('tagWatcher').watchForTag;
 
 /** @type {Array.<string>} */
 var WEB_VIEW_ATTRIBUTES = ['name', 'src', 'partition', 'autosize', 'minheight',
     'minwidth', 'maxheight', 'maxwidth'];
 
 
 // All exposed api methods for <webview>, these are forwarded to the browser
 // plugin.
@@ skipping 17 matching lines @@
   'loadabort' : ['url', 'isTopLevel', 'reason'],
   'loadcommit' : ['url', 'isTopLevel'],
   'loadredirect' : ['oldUrl', 'newUrl', 'isTopLevel'],
   'loadstart' : ['url', 'isTopLevel'],
   'loadstop' : [],
   'responsive' : ['processId'],
   'sizechanged': ['oldHeight', 'oldWidth', 'newHeight', 'newWidth'],
   'unresponsive' : ['processId']
 };
 
-window.addEventListener('DOMContentLoaded', function() {
-  watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
-});
+//window.addEventListener('DOMContentLoaded', function() {
+//  watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
+//});
 
 /**
  * @constructor
  */
 function WebView(webviewNode) {
   this.webviewNode_ = webviewNode;
   this.browserPluginNode_ = this.createBrowserPluginNode_();
   var shadowRoot = this.webviewNode_.webkitCreateShadowRoot();
   shadowRoot.appendChild(this.browserPluginNode_);
 
@@ skipping 316 matching lines @@
     chrome.webview.insertCSS.apply(null, args);
   }
 };
 
 /**
  * Implemented when the experimental API is available.
  * @private
  */
 WebView.prototype.maybeSetupExperimentalAPI_ = function() {};
 
+var w = chrome.app.window.current();
+window.console.log('***** current: ' + w);

[not at google - send to devlin, 2013/06/13 22:08:32]

i presume this doesn't really do anything?

[lazyboy, 2013/06/14 00:09:50]

Right, debug code, removed.

+
+appWindowNatives.OnCurrentContextReady(function() {
+  window.console.log('******* OnCurrentContextReady ********');
+  document.addEventListener('DOMContentLoaded', function() {

[not at google - send to devlin, 2013/06/13 22:08:32]

from reading the code it looks like this extra listener isn't necessary? I guess
I don't know the context of this change, but this callback is run when the
document is ready; does that not imply DOMContentLoaded? I.e. can you just add
watchForTag immediately.

[lazyboy, 2013/06/14 00:09:50]

This is the point where (new) document is created.
document.readyState == 'loading' at this point
we want document.readyState = 'interactive' or 'complete', so we need this
listener.

+    window.console.log('shim.DOMContentLoaded');
+    watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
+  });
+});
+
 exports.WebView = WebView;