Run shim's watchForTag on document.DOMContentLoaded

chrome/renderer/extensions/app_window_custom_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/app_window_custom_bindings.h"
 
 #include <string>
 
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/renderer/extensions/chrome_v8_context.h"
@@ skipping 41 matching lines @@
 
 AppWindowCustomBindings::AppWindowCustomBindings(
     Dispatcher* dispatcher,
     ChromeV8Context* context) : ChromeV8Extension(dispatcher, context) {
   RouteFunction("GetView",
       base::Bind(&AppWindowCustomBindings::GetView,
                  base::Unretained(this)));
   RouteFunction("OnContextReady",
       base::Bind(&AppWindowCustomBindings::OnContextReady,
                  base::Unretained(this)));
+  RouteFunction("OnCurrentContextReady",
+      base::Bind(&AppWindowCustomBindings::OnCurrentContextReady,
+                 base::Unretained(this)));
 }
 
 namespace {
 class LoadWatcher : public content::RenderViewObserver {
  public:
   LoadWatcher(v8::Isolate* isolate,

[not at google - send to devlin, 2013/06/13 22:08:32]

looks like isolate isn't used

[lazyboy, 2013/06/14 00:09:50]

Removed.

               content::RenderView* view,
               v8::Handle<v8::Function> cb)
       : content::RenderViewObserver(view),
         callback_(cb) {
   }
 
   virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE {
     CallbackAndDie(frame, true);
   }
 
@@ skipping 16 matching lines @@
       v8::Handle<v8::Value> args[] = {
         succeeded ? v8::True() : v8::False()
       };
       callback_->Call(global, 1, args);
     }
     delete this;
   }
 };
 }  // namespace
 
 v8::Handle<v8::Value> AppWindowCustomBindings::OnContextReady(

[not at google - send to devlin, 2013/06/13 22:08:32]

this doesn't actually have anything to do with app windows; nor is it about a
context being ready, it's about a document being ready. also the code is a
little bit wrong. it should probably be moved elsewhere particularly if you're
going to use it in web view.

maybe a RenderViewObserverNatives class or something. anyhow, see how it turns
out.

[lazyboy, 2013/06/14 00:09:50]

I've moved to a separate class RenderViewObserverNatives, exported it as
renderViewObserverNatives.
Better naming suggestions welcome (e.g. OnDocumentCreatedForCurrentContext...
long)

     const v8::Arguments& args) {
   if (args.Length() != 2)
     return v8::Undefined();
 
   if (!args[0]->IsInt32())
     return v8::Undefined();
   if (!args[1]->IsFunction())
     return v8::Undefined();
 
   int view_id = args[0]->Int32Value();
 
   content::RenderView* view = content::RenderView::FromRoutingID(view_id);
   if (!view)
     return v8::Undefined();
 
   v8::Handle<v8::Function> func = v8::Handle<v8::Function>::Cast(args[1]);
   new LoadWatcher(args.GetIsolate(), view, func);
 
   return v8::True();
 }
 
+v8::Handle<v8::Value> AppWindowCustomBindings::OnCurrentContextReady(
+    const v8::Arguments& args) {
+  printf("+++ %s\n", __PRETTY_FUNCTION__);
+  if (args.Length() != 1)
+    return v8::Undefined();
+
+  if (!args[0]->IsFunction())
+    return v8::Undefined();

[not at google - send to devlin, 2013/06/13 22:08:32]

just CHECK these, we call the method and it'd be a bug to call it wrongly.

I see it's being done above; may as well change that too

[lazyboy, 2013/06/14 00:09:50]

Done.

+
+  int routing_id = context()->GetRenderView()->GetRoutingID();
+  printf("found routing_id: %d\n", routing_id);
+
+  //int view_id = args[0]->Int32Value();
+  int view_id = routing_id;
+
+  content::RenderView* view = content::RenderView::FromRoutingID(view_id);

[not at google - send to devlin, 2013/06/13 22:08:32]

why go render view -> routing id -> render view here? all you need is
context()->RenderView() right?

[lazyboy, 2013/06/14 00:09:50]

Ah I was quick hacking, fixed.

+  if (!view)
+    return v8::Undefined();
+
+  v8::Handle<v8::Function> func = v8::Handle<v8::Function>::Cast(args[0]);
+  new LoadWatcher(args.GetIsolate(), view, func);
+
+  return v8::True();

[not at google - send to devlin, 2013/06/13 22:08:32]

might as well return undefined

again I see that code above it does this too, but that is unnecessarily verbose,
so yeah, feel free to fix it

[lazyboy, 2013/06/14 00:09:50]

Looks like the return value is used in
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/renderer/re...

I can remove this one though, not sure if being inconsistent with the code above
is OK.

+}
+
 v8::Handle<v8::Value> AppWindowCustomBindings::GetView(
     const v8::Arguments& args) {
   // TODO(jeremya): convert this to IDL nocompile to get validation, and turn
   // these argument checks into CHECK().
   if (args.Length() != 2)
     return v8::Undefined();
 
   if (!args[0]->IsInt32())
     return v8::Undefined();
 
@@ skipping 25 matching lines @@
   WebKit::WebFrame* frame = view->GetWebView()->mainFrame();
   frame->setOpener(opener);
   content::RenderThread::Get()->Send(
       new ExtensionHostMsg_ResumeRequests(view->GetRoutingID()));
 
   v8::Local<v8::Value> window = frame->mainWorldScriptContext()->Global();
   return window;
 }
 
 }  // namespace extensions