cloud_print/gcp20/prototype/gcp20_device.gyp - Issue 16975004: Finished DNS-SD server. Finished Privet-specified DNS-SD server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/gcp20/prototype/gcp20_device.gyp

Issue 16975004: Finished DNS-SD server. Finished Privet-specified DNS-SD server. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added strong control of size in PrivetDnsResponseBuilder. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cloud_print/gcp20/prototype/dns_sd_server.cc ('K') | « cloud_print/gcp20/prototype/gcp20_device.cc ('k') | cloud_print/gcp20/prototype/printer.h » ('j') | cloud_print/gcp20/prototype/printer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cloud_print/gcp20/prototype/gcp20_device.gyp

diff --git a/cloud_print/gcp20/prototype/gcp20_device.gyp b/cloud_print/gcp20/prototype/gcp20_device.gyp

index 7946960dbd2f5d9667143105ebb524c987f9f246..a530672a9fd18911f6112606cdc454ce41399b50 100644

--- a/cloud_print/gcp20/prototype/gcp20_device.gyp

+++ b/cloud_print/gcp20/prototype/gcp20_device.gyp

@@ -16,14 +16,33 @@

'targets': [

{

- 'target_name': 'gcp20_device',

- 'type': 'executable',

+ 'target_name': 'gcp20_device_lib',

+ 'type': 'static_library',

'dependencies': [

'<(DEPTH)/base/base.gyp:base',

'<(DEPTH)/net/net.gyp:net',

'sources': [

+ 'dns_packet_parser.cc',

+ 'dns_packet_parser.h',

'dns_sd_server.cc',

+ 'dns_sd_server.h',

+ 'dns_txt_builder.cc',

+ 'dns_txt_builder.h',

+ 'gcp20_device.cc',

+ 'printer.cc',

+ 'printer.h',

+ 'privet_dns_response_builder.cc',

+ 'privet_dns_response_builder.h',

+ ],

+ },

+ {

+ 'target_name': 'gcp20_device',

+ 'type': 'executable',

+ 'dependencies': [

+ 'gcp20_device.gyp:gcp20_device_lib',

+ ],

+ 'sources': [

'gcp20_device.cc',

'msvs_settings': {