Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1748)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1697483003: Properly scale the coordinate for TouchSelection when use-zoom-for-dsf mode is on. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index bfdbd00b584f1cc29e3d072122a635888e052669..d30c53ac49c48abaa442b21c217cf32f8b97f2ee 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1770,9 +1770,9 @@ void RenderFrameImpl::OnSelectRange(const gfx::Point& base,
const gfx::Point& extent) {
// This IPC is dispatched by RenderWidgetHost, so use its routing id.
Send(new InputHostMsg_SelectRange_ACK(GetRenderWidget()->routing_id()));
-
base::AutoReset<bool> handling_select_range(&handling_select_range_, true);
- frame_->selectRange(base, extent);
+ frame_->selectRange(render_view_->ConvertWindowPointToViewport(base),
+ render_view_->ConvertWindowPointToViewport(extent));
}
void RenderFrameImpl::OnAdjustSelectionByCharacterOffset(int start_adjust,
@@ -1808,9 +1808,9 @@ void RenderFrameImpl::OnMoveRangeSelectionExtent(const gfx::Point& point) {
// This IPC is dispatched by RenderWidgetHost, so use its routing id.
Send(new InputHostMsg_MoveRangeSelectionExtent_ACK(
GetRenderWidget()->routing_id()));
-
base::AutoReset<bool> handling_select_range(&handling_select_range_, true);
- frame_->moveRangeSelectionExtent(point);
+ frame_->moveRangeSelectionExtent(
+ render_view_->ConvertWindowPointToViewport(point));
}
void RenderFrameImpl::OnReplace(const base::string16& text) {

Powered by Google App Engine
This is Rietveld 408576698