Properly scale the coordinate for TouchSelection when use-zoom-for-dsf mode is on.

Properly scale the coordinate for TouchSelection when use-zoom-for-dsf mode is on.

* The selection bounds is sent as a part of meta data.
 painted_dsf is set to 2x on 2x device when use-zoom-for-dsf mode is on.
* The bounds sent from browser is in Window coordinates. It should be converted to Viweport, which is pixels when use-zoom-for-dsf mode is on.

BUG=585043
TEST=LayerTreeHostimplTestWithPaintedDeviceScaleFactor.SelectionBoundsPassedToCompositorFrameMetaData
 manually tested on high DPI device
TBR=oshima@chromium.org

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

[oshima, 2016-02-13 01:20:56]

Description was changed from

==========
TouchSelection

BUG=
==========

to

==========
TouchSelection

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[oshima, 2016-02-16 08:09:24]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 08:10:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697483003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697483003/20001

[commit-bot: I haz the power, 2016-02-16 09:18:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 09:18:48]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-02-19 20:56:59]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 20:58:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697483003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697483003/80001

[oshima, 2016-02-19 23:16:01]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 23:20:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697483003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697483003/100001

[commit-bot: I haz the power, 2016-02-20 00:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-20 00:40:10]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-02-22 22:34:25]

Description was changed from

==========
TouchSelection

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
TouchSelection

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[oshima, 2016-02-22 22:34:25]

oshima@chromium.org changed reviewers:
+ christiank@opera.com

[oshima, 2016-02-22 22:36:24]

oshima@chromium.org changed reviewers:
+ mohsen@chromium.org
- christiank@opera.com

[oshima, 2016-02-22 22:38:08]

Description was changed from

==========
TouchSelection

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
TouchSelection

BUG=585043
TEST=LayerTreeHostimplTestWithPaintedDeviceScaleFactor.SelectionBoundsPassedToCompositorFrameMetaData
 manually tested on high DPI device

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[oshima, 2016-02-22 22:41:00]

Description was changed from

==========
TouchSelection

BUG=585043
TEST=LayerTreeHostimplTestWithPaintedDeviceScaleFactor.SelectionBoundsPassedToCompositorFrameMetaData
 manually tested on high DPI device

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Properly scale the coordinate for TouchSelection when use-zoom-for-dsf mode is
on.

* The selection bounds is sent as a part of meta data.
 painted_dsf is set to 2x on 2x device when use-zoom-for-dsf mode is on.
* The bounds sent from browser is in Window coordinates. It should be converted
to Viweport, which is pixels when use-zoom-for-dsf mode is on.

BUG=585043
TEST=LayerTreeHostimplTestWithPaintedDeviceScaleFactor.SelectionBoundsPassedToCompositorFrameMetaData
 manually tested on high DPI device

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[oshima, 2016-02-22 22:42:03]

mohsen@, I'm sending this to you because you seemed to have worked on this
feature before. Please let me know if I should send it to someone else.

[oshima, 2016-02-22 22:43:11]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 22:44:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697483003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697483003/120001

[commit-bot: I haz the power, 2016-02-23 00:01:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 00:01:53]

Dry run: This issue passed the CQ dry run.

[mohsen, 2016-02-23 18:34:50]

Changes look good to me, though I've mostly worked on the browser side of touch
selection and I'm not very familiar with the renderer side.

[oshima, 2016-02-23 18:46:53]

oshima@chromium.org changed reviewers:
+ danakj@chromium.org, sievers@chromium.org

[oshima, 2016-02-23 18:46:54]

+danakj@ -> cc/ owner
+sievers@ -> content/renderer owner, who also revered the CL
https://codereview.chromium.org/657803002, which modified touch selection code
in renderer.

[oshima, 2016-02-25 19:00:33]

friendly ping

[danakj, 2016-02-25 19:37:22]

https://codereview.chromium.org/1697483003/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/1697483003/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_impl_unittest.cc:8032:
EXPECT_EQ(gfx::ScalePoint(gfx::PointF(selection_bottom),
Does this all mean that there is some input to the compositor that isn't being
scaled by the painted device scale factor?

I'm not expecting cc to have to use the painted DSF for anything other than
passing it along. So I'd expect all inputs to already be scaled.

[oshima, 2016-02-25 21:52:03]

https://codereview.chromium.org/1697483003/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/1697483003/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_impl_unittest.cc:8032:
EXPECT_EQ(gfx::ScalePoint(gfx::PointF(selection_bottom),
On 2016/02/25 19:37:22, danakj wrote:
> Does this all mean that there is some input to the compositor that isn't being
> scaled by the painted device scale factor?
> 
> I'm not expecting cc to have to use the painted DSF for anything other than
> passing it along. So I'd expect all inputs to already be scaled.

This is an output from compositor. Currently, cc/ is responsible for computing
the selection bounds, which is attached to the frame metadata, which in turn, is
consumed by browser process in DIP.  See ComputeViewportSelectionBound (It
converts from layer -> screen -> dip).

Other selection code lives in content/renderer so it's not clear to me why this
is in cc/ though.

While it's technically possible to move the conversion to browser process, but
I'd like to avoid it because browser currently expects to receive DIP from
renderer process.

[oshima, 2016-03-07 00:59:13]

Description was changed from

==========
Properly scale the coordinate for TouchSelection when use-zoom-for-dsf mode is
on.

* The selection bounds is sent as a part of meta data.
 painted_dsf is set to 2x on 2x device when use-zoom-for-dsf mode is on.
* The bounds sent from browser is in Window coordinates. It should be converted
to Viweport, which is pixels when use-zoom-for-dsf mode is on.

BUG=585043
TEST=LayerTreeHostimplTestWithPaintedDeviceScaleFactor.SelectionBoundsPassedToCompositorFrameMetaData
 manually tested on high DPI device

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Properly scale the coordinate for TouchSelection when use-zoom-for-dsf mode is
on.

* The selection bounds is sent as a part of meta data.
 painted_dsf is set to 2x on 2x device when use-zoom-for-dsf mode is on.
* The bounds sent from browser is in Window coordinates. It should be converted
to Viweport, which is pixels when use-zoom-for-dsf mode is on.

BUG=585043
TEST=LayerTreeHostimplTestWithPaintedDeviceScaleFactor.SelectionBoundsPassedToCompositorFrameMetaData
 manually tested on high DPI device
TBR=oshima@chromium.org

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========