Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2025)

Issue 1697473002: [interpreter] Add bytecodes for JumpIfNotHole with constant (Closed)

Created:
4 years, 10 months ago by oth
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, oth, mythria
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add bytecodes for JumpIfNotHole with constant Adds JumpIfNotHoleConstant and JumpIfNotHoleConstantWide bytecodes and removes JumpIfHole bytecode. In situations with large numbers of constants, the generator would fail because an 8-bit constant could not be reserved for JumpIfHole/JumpIfNotHole and so a 16-bit constant would be reserved. Then when patching the bytecode the patcher would discover there was no wide constant variant of the emitted jump. BUG=v8:4280, v8:4680 LOG=N Committed: https://crrev.com/47c08f5f71fcdaeba3dff39fd292fcfe44c6d23a Cr-Commit-Position: refs/heads/master@{#33952}

Patch Set 1 #

Patch Set 2 : Fix an inconsistency. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -73 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 3 chunks +19 lines, -14 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 4 chunks +27 lines, -32 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/bytecodes.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 1 chunk +18 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
oth
rmcilroy@chromium.org: PTAL. mstarzinger@chromium.org: PTAL at compiler. This should also fix a additional tests after the ...
4 years, 10 months ago (2016-02-12 09:22:20 UTC) #2
Michael Starzinger
LGTM.
4 years, 10 months ago (2016-02-12 09:57:41 UTC) #3
rmcilroy
LGTM.
4 years, 10 months ago (2016-02-12 10:22:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697473002/40001
4 years, 10 months ago (2016-02-12 14:52:46 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-12 15:24:06 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 15:24:52 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47c08f5f71fcdaeba3dff39fd292fcfe44c6d23a
Cr-Commit-Position: refs/heads/master@{#33952}

Powered by Google App Engine
This is Rietveld 408576698