Faster run-bindings-tests

Source/bindings/scripts/idl_compiler.py

 #!/usr/bin/python
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 57 matching lines @@
 # FIXME: import from utilities once moved into same directory (lines vs. text)
 def write_file(new_text, destination_filename, only_if_changed):
     if only_if_changed and os.path.isfile(destination_filename):
         with open(destination_filename) as destination_file:
             if destination_file.read() == new_text:
                 return
     with open(destination_filename, 'w') as destination_file:
         destination_file.write(new_text)
 
 
-def main():
-    options, idl_filename = parse_options()
+def compile_idl(idl_filename, output_directory, idl_attributes_file,

[Nils Barth (inactive), 2014/03/03 01:32:48]

Initialization makes this a bit ugly.
Let's make the compiler into a class, that way we have one initialization,
and it's a very simple call to write the file.

You can then either pass a different parameter in the initialization,
or derive a class and override the methods
(or maybe both if that's easier).

How about:
class IdlCompiler(object):
    def __init__(self, output_directory, interface_dependencies_file,
interfaces_info_file=None, only_if_changed=False, reader=None,
code_generator=None):
        self.output_directory = output_directory
        # interfaces_info initialization
        self.reader = reader or IdlReader(interfaces_info, idl_attributes_file,
output_directory)
        self.code_generator = code_generator or CodeGeneratorV8(interfaces_info,
output_directory)

    def compile_idl(self, idl_filename):
        # compile and write

[Nils Barth (inactive), 2014/03/03 06:45:49]

This is useful enough that I'm posting it in another CL
(just makes the class).
Make an IdlCompiler class
https://codereview.chromium.org/178003010/

For hooking in Dart, you'll just need to add override fields
for the reader/CG, or simply monkey patch it after initialization.

[terry, 2014/03/13 19:58:18]

Right - you've added the abstract class.
On 2014/03/03 01:32:48, Nils Barth wrote:

+                interfaces_info_file=None, only_if_changed=True, reader=None,
+                code_generator=CodeGeneratorV8):
     basename = os.path.basename(idl_filename)
     interface_name, _ = os.path.splitext(basename)
-    output_directory = options.output_directory
-    only_if_changed = options.write_file_only_if_changed
+    output_directory = output_directory

[Nils Barth (inactive), 2014/03/03 01:32:48]

I don't think this line is necessary ;)

[terry, 2014/03/13 19:58:18]

Not necessary since self.output_directory is set on init.

 
-    interfaces_info_filename = options.interfaces_info_file
+    interfaces_info_filename = interfaces_info_file
     if interfaces_info_filename:
         with open(interfaces_info_filename) as interfaces_info_file:
             interfaces_info = pickle.load(interfaces_info_file)
     else:
         interfaces_info = None
 
-    reader = IdlReader(interfaces_info, options.idl_attributes_file, output_directory)
+    if reader == None:
+        reader = IdlReader(interfaces_info, idl_attributes_file, output_directory)
     definitions = reader.read_idl_definitions(idl_filename)
 
-    code_generator = CodeGeneratorV8(interfaces_info, output_directory)
-    header_text, cpp_text = code_generator.generate_code(definitions, interface_name)
+    cg = code_generator(interfaces_info, output_directory)

[Nils Barth (inactive), 2014/03/03 01:32:48]

In Blink we use full words for names, so |code_generator|, not |cg|.
(Admittedly, C/Go-style |r| for reader and |cg| for |code_generator| would be
fun ;)

[terry, 2014/03/13 19:58:18]

ok.
On 2014/03/03 01:32:48, Nils Barth wrote:

+    header_text, cpp_text = cg.generate_code(definitions, interface_name)
 
     header_filename = os.path.join(output_directory, 'V8%s.h' % interface_name)
     cpp_filename = os.path.join(output_directory, 'V8%s.cpp' % interface_name)
     write_file(header_text, header_filename, only_if_changed)
     write_file(cpp_text, cpp_filename, only_if_changed)
 
+    return reader
+
+
+def main():
+    options, idl_filename = parse_options()
+    compile_idl(idl_filename, options.output_directory, options.idl_attributes_file,
+                options.interfaces_info_file, options.write_file_only_if_changed)
+
 
 if __name__ == '__main__':
     sys.exit(main())