Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1697423003: Support blocks in asm->wasm global section. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support blocks in asm->wasm global section. The parser can fold together comma separated declarations into a single block. The AsmWasmBuilder needs to support this case in order to handle asm.js modules that use this form. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/6357ad847bf6a6f6d9cbbc9fb1077623641283ff Cr-Commit-Position: refs/heads/master@{#34048}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M src/wasm/asm-wasm-builder.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
bradn
4 years, 10 months ago (2016-02-16 16:49:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697423003/1
4 years, 10 months ago (2016-02-16 16:49:36 UTC) #3
titzer
On 2016/02/16 16:49:36, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 10 months ago (2016-02-16 16:53:01 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 17:13:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697423003/1
4 years, 10 months ago (2016-02-16 18:33:00 UTC) #8
commit-bot: I haz the power
Failed to apply patch for test/mjsunit/wasm/asm-wasm.js: While running git apply --index -3 -p1; error: patch ...
4 years, 10 months ago (2016-02-16 18:35:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697423003/20001
4 years, 10 months ago (2016-02-16 19:03:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 19:33:34 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 19:33:58 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6357ad847bf6a6f6d9cbbc9fb1077623641283ff
Cr-Commit-Position: refs/heads/master@{#34048}

Powered by Google App Engine
This is Rietveld 408576698