Issue 1697373002: dart2js cps: Fix inlining of stringify.

Issue 1697373002: dart2js cps: Fix inlining of stringify. (Closed)

Created:
4 years, 10 months ago by asgerf

Modified:
4 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang), Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Fix inlining of stringify. The rewrite Stringify(x) -> x.toString() is only safe when the toString method is known to return a string. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1c698c183be2d74bfb1576cffb4476e6d77317e6

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -62 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		1 chunk	+12 lines, -8 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/cps_ir/expected/constructor_7.js	View		1 chunk	+5 lines, -10 lines	0 comments	Download
M	tests/compiler/dart2js/cps_ir/expected/constructor_8.js	View		1 chunk	+6 lines, -10 lines	0 comments	Download
M	tests/compiler/dart2js/cps_ir/expected/runtime_types_1.js	View		1 chunk	+5 lines, -10 lines	0 comments	Download
M	tests/compiler/dart2js/cps_ir/expected/runtime_types_2.js	View		1 chunk	+5 lines, -10 lines	0 comments	Download
M	tests/compiler/dart2js/cps_ir/expected/runtime_types_3.js	View		1 chunk	+5 lines, -10 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

asgerf

4 years, 10 months ago (2016-02-17 09:58:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1c698c183be2d74bfb1576cffb4476e6d77317e6 (presubmit successful).