Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: src/a64/macro-assembler-a64.cc

Issue 169733003: A64: Remove early_exit unused mechanism in CompareMap. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/a64/macro-assembler-a64.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/macro-assembler-a64.cc
diff --git a/src/a64/macro-assembler-a64.cc b/src/a64/macro-assembler-a64.cc
index 1e8da54314a5fa2434071cb051a8281126f38301..55bf848844764b67806ce04af24f07781de08722 100644
--- a/src/a64/macro-assembler-a64.cc
+++ b/src/a64/macro-assembler-a64.cc
@@ -3380,18 +3380,14 @@ void MacroAssembler::CompareInstanceType(Register map,
void MacroAssembler::CompareMap(Register obj,
Register scratch,
- Handle<Map> map,
- Label* early_success) {
- // TODO(jbramley): The early_success label isn't used. Remove it.
+ Handle<Map> map) {
Ldr(scratch, FieldMemOperand(obj, HeapObject::kMapOffset));
- CompareMap(scratch, map, early_success);
+ CompareMap(scratch, map);
}
void MacroAssembler::CompareMap(Register obj_map,
- Handle<Map> map,
- Label* early_success) {
- // TODO(jbramley): The early_success label isn't used. Remove it.
+ Handle<Map> map) {
Cmp(obj_map, Operand(map));
}
@@ -3405,10 +3401,8 @@ void MacroAssembler::CheckMap(Register obj,
JumpIfSmi(obj, fail);
}
- Label success;
- CompareMap(obj, scratch, map, &success);
+ CompareMap(obj, scratch, map);
B(ne, fail);
- Bind(&success);
}
@@ -3432,10 +3426,9 @@ void MacroAssembler::CheckMap(Register obj_map,
if (smi_check_type == DO_SMI_CHECK) {
JumpIfSmi(obj_map, fail);
}
- Label success;
- CompareMap(obj_map, map, &success);
+
+ CompareMap(obj_map, map);
B(ne, fail);
- Bind(&success);
}
« no previous file with comments | « src/a64/macro-assembler-a64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698