Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 1697283002: [runtime] Turn MigrateFastTo* into static helpers (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Turn MigrateFastTo* into static helpers BUG= Committed: https://crrev.com/d99cbb7a74e0ed41cb65ab197e355a8b02e8a8c9 Cr-Commit-Position: refs/heads/master@{#34013}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -176 lines) Patch
M src/objects.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 4 chunks +169 lines, -171 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-16 04:34:57 UTC) #2
Benedikt Meurer
lgtm https://codereview.chromium.org/1697283002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1697283002/diff/1/src/objects.cc#newcode2831 src/objects.cc:2831: static void MigrateFastToFast(Handle<JSObject> object, Handle<Map> new_map) { Nit: ...
4 years, 10 months ago (2016-02-16 04:55:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697283002/20001
4 years, 10 months ago (2016-02-16 05:18:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 05:56:55 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 05:57:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d99cbb7a74e0ed41cb65ab197e355a8b02e8a8c9
Cr-Commit-Position: refs/heads/master@{#34013}

Powered by Google App Engine
This is Rietveld 408576698