src/IceTargetLoweringARM32.cpp - Issue 1697263007: Add fabs(<4 x float>) to the integrated ARM assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringARM32.cpp

Issue 1697263007: Add fabs(<4 x float>) to the integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nits. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringARM32.cpp

diff --git a/src/IceTargetLoweringARM32.cpp b/src/IceTargetLoweringARM32.cpp

index b3e43eb2ff5f6f3d0acb6076361b1df36c6da025..b4a9b67517e474b5583308e79632072b594f710c 100644

--- a/src/IceTargetLoweringARM32.cpp

+++ b/src/IceTargetLoweringARM32.cpp

@@ -4944,10 +4944,6 @@ void TargetARM32::lowerIntrinsicCall(const InstIntrinsicCall *Instr) {

case Intrinsics::Fabs: {

Type DestTy = Dest->getType();

Variable *T = makeReg(DestTy);

- if (isVectorType(DestTy)) {

- UnimplementedLoweringError(this, Instr);

- return;

- }

_vabs(T, legalizeToReg(Instr->getArg(0)));

_mov(Dest, T);

return;

« no previous file with comments | « src/IceInstARM32.cpp ('k') | tests_lit/assembler/arm32/vabs-vec.ll » ('j') | no next file with comments »