Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: src/IceInstARM32.cpp

Issue 1697263007: Add fabs(<4 x float>) to the integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index 9d6999b2456f22ec41cd83c484bc7395babfc6c6..aee7da7d6e56d92ee369179afffd6de655a18689 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -2464,18 +2464,20 @@ void InstARM32Vabs::emitIAS(const Cfg *Func) const {
const Variable *Dest = getDest();
switch (Dest->getType()) {
default:
- // TODO(kschimpf): Implement vector fabs.
- Asm->setNeedsTextFixup();
- break;
+ llvm::report_fatal_error("fabs not defined on type " +
+ typeIceString(Dest->getType()));
case IceType_f32:
Asm->vabss(Dest, getSrc(0), getPredicate());
break;
case IceType_f64:
Asm->vabsd(Dest, getSrc(0), getPredicate());
break;
+ case IceType_v4f32:
+ assert(CondARM32::isUnconditional(getPredicate()) &&
+ "fabs must be unconditional");
+ Asm->vabsq(Dest, getSrc(0));
}
- if (Asm->needsTextFixup())
- emitUsingTextFixup(Func);
+ assert(!Asm->needsTextFixup());
}
void InstARM32Vabs::dump(const Cfg *Func) const {
« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698