Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1697263006: If pthread stack size can't be determined, make a conservative guess. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

If pthread stack size can't be determined, make a conservative guess. Default the underestimated stack size for pthreads-based (non OSX) to 512k. R=haraken BUG=581913 Committed: https://crrev.com/5e6e9067b2816c568919bf955b7f34429aee4c2d Cr-Commit-Position: refs/heads/master@{#375814}

Patch Set 1 #

Patch Set 2 : sync comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp View 1 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-16 20:45:05 UTC) #4
haraken
LGTM
4 years, 10 months ago (2016-02-17 03:28:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697263006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697263006/20001
4 years, 10 months ago (2016-02-17 06:21:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 06:46:41 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 06:48:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e6e9067b2816c568919bf955b7f34429aee4c2d
Cr-Commit-Position: refs/heads/master@{#375814}

Powered by Google App Engine
This is Rietveld 408576698