third_party/WebKit/LayoutTests/fast/css/variables/multiple-writes-to-inline-style.html - Issue 1697233003: Allow custom property variant of setProperty to find existing references

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/variables/multiple-writes-to-inline-style.html

Issue 1697233003: Allow custom property variant of setProperty to find existing references (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <div id='testElem'></div>

	5 <script>

	6

	7 test(function() {

	8 assert_equals(testElem.getAttribute('style'), null);

	9 testElem.style.setProperty('--foo', 'first');

	10 assert_equals(testElem.style.getPropertyValue('--foo'), 'first');

	11 assert_equals(getComputedStyle(testElem).getPropertyValue('--foo'), 'first');

	12 assert_equals(testElem.getAttribute('style'), '--foo: first;');

	13 testElem.style.setProperty('--foo', 'second');

	14 assert_equals(testElem.style.getPropertyValue('--foo'), 'second');

	15 // assert_equals(getComputedStyle(testElem).getPropertyValue('--foo'), 'second ');
	Timothy Loh 2016/02/16 23:49:39 uncomment this? uncomment this? shans 2016/02/17 02:41:35 It will fail, due to another bug I'm currently wor Show quoted text On 2016/02/16 at 23:49:39, Timothy Loh wrote: > uncomment this? It will fail, due to another bug I'm currently working on. Timothy Loh 2016/02/17 23:54:10 Maybe better to uncomment and check in a failing e Show quoted text On 2016/02/17 02:41:35, shans wrote: > On 2016/02/16 at 23:49:39, Timothy Loh wrote: > > uncomment this? > > It will fail, due to another bug I'm currently working on. Maybe better to uncomment and check in a failing expectation then?
	16 assert_equals(testElem.getAttribute('style'), '--foo: second;');

	17 }, "subsequent writes to inline style overwrite older values.")

	18

	19 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/StylePropertySet.h » ('j') | third_party/WebKit/Source/core/css/StylePropertySet.cpp » ('J')