Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1697233002: Reland of land "media: Refactor MojoMediaClient" with fix. (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 10 months ago
Reviewers:
jam, Nico, xhwang, alokp
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, lcwu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, halliwell+watch_chromium.org, gunsch+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of land "media: Refactor MojoMediaClient" with fix. (patchset #2 id:260001 of https://codereview.chromium.org/1702453002/ ) Reason for revert: Unrelated to https://crbug.com/586902. Relanding. Original issue's description: > Revert of Reland "media: Refactor MojoMediaClient" with fix. (patchset #2 id:20001 of https://codereview.chromium.org/1690213002/ ) > > Reason for revert: > Suspected to break a layout test on android. > https://crbug.com/586902 > > Original issue's description: > > Reland "media: Refactor MojoMediaClient" with fix. > > > > This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2. > > > > Instead of specifying a platform based MojoMediaClient at compile time, > > provide the capability of setting one at run time. This improves the flexibility > > of using MojoMediaApplication in different cases. For example, on desktop, we > > may want to run the MojoMediaApplication in the utility process (for the CDM > > service) and in the GPU process (for hardware decoding). In those two cases, > > we'll want to specify two different MojoMediaClients even though we are on the > > same platform. > > > > TBR=alokp@chromium.org > > BUG=570357, 571155 > > TBR=alokp@chromium.org,jam@chromium.org,thakis@chromium.org,xhwang@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=586902, 570357, 571155 TBR=alokp@chromium.org,jam@chromium.org,thakis@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=586902, 570357, 571155 Committed: https://crrev.com/c26ffdddc06e2ee306a31eca0905c1fe3287bcc7 Cr-Commit-Position: refs/heads/master@{#375491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -146 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chromecast/media/mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A chromecast/media/mojo/cast_mojo_media_client.h View 1 chunk +32 lines, -0 lines 0 comments Download
M chromecast/media/mojo/cast_mojo_media_client.cc View 1 chunk +16 lines, -21 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/BUILD.gn View 5 chunks +19 lines, -21 lines 0 comments Download
A media/mojo/services/android_mojo_media_client.h View 1 chunk +28 lines, -0 lines 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 3 chunks +10 lines, -20 lines 0 comments Download
A media/mojo/services/default_mojo_media_client.h View 1 chunk +47 lines, -0 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.cc View 2 chunks +45 lines, -65 lines 0 comments Download
M media/mojo/services/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_cdm_service_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_media_application.h View 3 chunks +16 lines, -1 line 0 comments Download
M media/mojo/services/mojo_media_application.cc View 2 chunks +30 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_media_client.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
hiroshige
Created Reland of land "media: Refactor MojoMediaClient" with fix.
4 years, 10 months ago (2016-02-15 21:51:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697233002/1
4 years, 10 months ago (2016-02-15 21:51:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 21:51:58 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:50:49 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c26ffdddc06e2ee306a31eca0905c1fe3287bcc7
Cr-Commit-Position: refs/heads/master@{#375491}

Powered by Google App Engine
This is Rietveld 408576698