Issue 169723003: Allow HTTP response without reason phrase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 169723003: Allow HTTP response without reason phrase (Closed)

Created:
6 years, 10 months ago by Søren Gjesse

Modified:
6 years, 10 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow HTTP response without reason phrase Turns out some HTTP servers does not adhere to the spec when sending response messages. This issue was found with the AppEngine dev_appserver which does not send a reason phrase for some requests. R=ajohnsen@google.com BUG=http://dartbug.com/16756 Committed: https://code.google.com/p/dart/source/detail?r=32727

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	M	sdk/lib/io/http_parser.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	A	tests/standalone/io/http_no_reason_phrase_test.dart	View		1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

6 years, 10 months ago (2014-02-17 14:54:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32727 (presubmit successful).

Expand Messages | Collapse Messages