Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1697203002: Switch to downloaded SDK executable, drop executables in testing/bin. (Closed)

Created:
4 years, 10 months ago by Bill Hesse
Modified:
4 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1, Søren Gjesse
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch to downloaded SDK executable, drop executables in testing/bin. BUG=https://github.com/dart-lang/sdk/issues/24311 R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/2573093c506671d7028b8618239209336fc89cf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -86 lines) Patch
M DEPS View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/bots/cross-vm.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_tarball.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/dom/dom.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/test.py View 1 chunk +2 lines, -1 line 0 comments Download
D tools/testing/bin/linux/dart.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/testing/bin/linux/dart-arm.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/testing/bin/linux/dart-mips.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/testing/bin/macos/dart.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/testing/bin/windows/dart.exe.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/co19_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/http_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/utils.py View 2 chunks +7 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 10 months ago (2016-02-15 16:05:27 UTC) #2
ricow1
lgtm
4 years, 10 months ago (2016-02-15 16:08:04 UTC) #3
Bill Hesse
4 years, 10 months ago (2016-02-15 16:11:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2573093c506671d7028b8618239209336fc89cf6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698