Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: components/sessions/core/tab_restore_service_helper.h

Issue 1697183003: Remove HostDesktopType from sessions and tab restore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-19
Patch Set: mac Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/core/tab_restore_service_helper.h
diff --git a/components/sessions/core/tab_restore_service_helper.h b/components/sessions/core/tab_restore_service_helper.h
index 252adad0735fd8ed7e8ec270d8d22c20b3e7318c..8a9ed4840820534733f49219e5576f76bd5ea0b6 100644
--- a/components/sessions/core/tab_restore_service_helper.h
+++ b/components/sessions/core/tab_restore_service_helper.h
@@ -77,12 +77,10 @@ class SESSIONS_EXPORT TabRestoreServiceHelper {
void BrowserClosed(LiveTabContext* context);
void ClearEntries();
const Entries& entries() const;
- std::vector<LiveTab*> RestoreMostRecentEntry(LiveTabContext* context,
- int host_desktop_type);
+ std::vector<LiveTab*> RestoreMostRecentEntry(LiveTabContext* context);
Tab* RemoveTabEntryById(SessionID::id_type id);
std::vector<LiveTab*> RestoreEntryById(LiveTabContext* context,
SessionID::id_type id,
- int host_desktop_type,
WindowOpenDisposition disposition);
// Notifies observers the tabs have changed.
@@ -122,16 +120,13 @@ class SESSIONS_EXPORT TabRestoreServiceHelper {
// This is a helper function for RestoreEntryById() for restoring a single
// tab. If |context| is NULL, this creates a new window for the entry. This
- // returns the LiveTabContext into which the tab was restored.
- // |disposition| will be respected, but if it is UNKNOWN then the tab's
- // original attributes will be respected instead. If a new
- // LiveTabContext needs to be created for this tab,
- // |host_desktop_type| will be passed to
- // TabRestoreServiceClient::CreateLiveTabContext(). If present,
- // |live_tab| will be populated with the LiveTab of the restored tab.
+ // returns the LiveTabContext into which the tab was restored. |disposition|
+ // will be respected, but if it is UNKNOWN then the tab's original attributes
+ // will be respected instead. If a new LiveTabContext needs to be created for
+ // this tab, If present, |live_tab| will be populated with the LiveTab of the
+ // restored tab.
LiveTabContext* RestoreTab(const Tab& tab,
LiveTabContext* context,
- int host_desktop_type,
WindowOpenDisposition disposition,
LiveTab** live_tab);
« no previous file with comments | « components/sessions/core/tab_restore_service_client.h ('k') | components/sessions/core/tab_restore_service_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698