Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: components/sessions/core/tab_restore_service_client.h

Issue 1697183003: Remove HostDesktopType from sessions and tab restore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-19
Patch Set: mac Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/core/tab_restore_service_client.h
diff --git a/components/sessions/core/tab_restore_service_client.h b/components/sessions/core/tab_restore_service_client.h
index c7cb3f78ca30cca1e181893acb3e351ba691a079..1f968b8b5fe8dc896dd83fe15da657c3ca6efdaf 100644
--- a/components/sessions/core/tab_restore_service_client.h
+++ b/components/sessions/core/tab_restore_service_client.h
@@ -36,27 +36,19 @@ class SESSIONS_EXPORT TabRestoreServiceClient {
public:
virtual ~TabRestoreServiceClient();
- // Creates a LiveTabContext instance that is associated with
- // |host_desktop_type| and |app_name|. May return nullptr (e.g., if the
- // embedder does not support LiveTabContext functionality).
- // Note that |host_desktop_type| is opaque to the component; the only values
- // that will be passed here are those that have been passed *in* to the
- // component from the embedder via TabRestoreService.
- virtual LiveTabContext* CreateLiveTabContext(int host_desktop_type,
- const std::string& app_name) = 0;
+ // Creates a LiveTabContext instance that is associated with |app_name|. May
+ // return nullptr (e.g., if the embedder does not support LiveTabContext
+ // functionality).
+ virtual LiveTabContext* CreateLiveTabContext(const std::string& app_name) = 0;
// Returns the LiveTabContext instance that is associated with
// |tab|, or null if there is no such instance.
virtual LiveTabContext* FindLiveTabContextForTab(const LiveTab* tab) = 0;
- // Returns the LiveTabContext instance that is associated with
- // |desired_id| and |host_desktop_type|, or null if there is no such instance.
- // Note that |host_desktop_type| is opaque to the component; the only values
- // that will be passed here are those that have been passed *in* to the
- // component from the embedder via TabRestoreService.
+ // Returns the LiveTabContext instance that is associated with |desired_id|,
+ // or null if there is no such instance.
virtual LiveTabContext* FindLiveTabContextWithID(
- SessionID::id_type desired_id,
- int host_desktop_type) = 0;
+ SessionID::id_type desired_id) = 0;
// Returns whether a given URL should be tracked for restoring.
virtual bool ShouldTrackURLForRestore(const GURL& url) = 0;
« no previous file with comments | « components/sessions/core/tab_restore_service.h ('k') | components/sessions/core/tab_restore_service_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698