Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 1697173002: [runtime] Optimize MigrateFastToFast for the transition case (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Optimize MigrateFastToFast for the transition case This avoids quite expensive computation further downstream. Committed: https://crrev.com/8a286ecee26a056f685d27d9cdab795c59b3b073 Cr-Commit-Position: refs/heads/master@{#34007}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -32 lines) Patch
M src/objects.cc View 1 3 chunks +47 lines, -32 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-15 14:28:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697173002/1
4 years, 10 months ago (2016-02-15 14:29:07 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/2812) v8_win_rel_ng_triggered on ...
4 years, 10 months ago (2016-02-15 14:46:18 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697173002/40001
4 years, 10 months ago (2016-02-15 15:23:47 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 15:46:50 UTC) #12
Igor Sheludko
Nice! lgtm
4 years, 10 months ago (2016-02-15 18:18:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697173002/40001
4 years, 10 months ago (2016-02-15 19:01:10 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-15 19:02:35 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 19:03:11 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a286ecee26a056f685d27d9cdab795c59b3b073
Cr-Commit-Position: refs/heads/master@{#34007}

Powered by Google App Engine
This is Rietveld 408576698