Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 1697153002: [runtime] Add fast path to update LookupIterator in simple cases (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Add fast path to update LookupIterator in simple cases By not calling ReloadPropertyInformation, we avoid expensive descriptor array lookup. BUG= Committed: https://crrev.com/4c41d007d932ed6eba7514f2d4e44def61cd5fb8 Cr-Commit-Position: refs/heads/master@{#33995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M src/lookup.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/lookup.cc View 2 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-15 13:07:50 UTC) #2
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-15 13:44:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697153002/1
4 years, 10 months ago (2016-02-15 13:52:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 14:13:59 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 14:14:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c41d007d932ed6eba7514f2d4e44def61cd5fb8
Cr-Commit-Position: refs/heads/master@{#33995}

Powered by Google App Engine
This is Rietveld 408576698