Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1696973002: Revert of Reland #1 Remove the is_loading_ field from WebContentsImpl (Closed)

Created:
4 years, 10 months ago by lazyboy
Modified:
4 years, 10 months ago
Reviewers:
clamy, nasko
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, ajwong+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland #1 Remove the is_loading_ field from WebContentsImpl (patchset #3 id:40001 of https://codereview.chromium.org/1690653003/ ) Reason for revert: A bunch of SessionHistoryTest.* tests started being flaky on Cast Linux bot after the CL landed. See below for details: Before the CL I've checked 5 builds that never had any failure: https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18670 https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18669 https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18668 https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18667 After/at the CL a lot of the builds either completely failed and passed on retry: https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18671 SessionHistoryTest.FrameBackForward https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18672 SessionHistoryTest.FragmentBackForward SessionHistoryTest.HistoryLength https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18677 SessionHistoryTest.FragmentBackForward https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18678 SessionHistoryTest.FragmentBackForward https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18679 SessionHistoryTest.BasicBackForward SessionHistoryTest.HistoryLength Original issue's description: > Reland #1 Remove the is_loading_ field from WebContentsImpl > > The CL was reverted since it introduced flakyness on the > SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the > ChromiumOS dbg bot. > > Original commit message: > This CL removes the is_loading_ field from WebContents, in favor of only > tracking the loading state through the FrameTree. Currently the loading state > is tracked in both, leading to more complexity in the code. > > BUG=571887, 298193 > TBR=rockot@chromium.org,nick@chromium.org,carlosk@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation TBR=nasko@chromium.org,clamy@chromium.org,rockot@chromium.org BUG=571887, 298193, 586633 Committed: https://crrev.com/268f1bf33d61c34c9ebcb40947f1d262a31ad0b8 Cr-Commit-Position: refs/heads/master@{#375323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -362 lines) Patch
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/frame_tree.h View 4 chunks +1 line, -41 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 3 chunks +2 lines, -44 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 4 chunks +10 lines, -35 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 3 chunks +12 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +8 lines, -13 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +4 lines, -15 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 5 chunks +4 lines, -16 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 10 chunks +28 lines, -38 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 6 chunks +1 line, -21 lines 0 comments Download
M content/browser/site_instance_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 4 chunks +9 lines, -16 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 12 chunks +19 lines, -38 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 4 chunks +25 lines, -16 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +1 line, -23 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.cc View 1 chunk +2 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lazyboy
Created Revert of Reland #1 Remove the is_loading_ field from WebContentsImpl
4 years, 10 months ago (2016-02-13 00:15:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696973002/1
4 years, 10 months ago (2016-02-13 00:18:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-13 01:53:30 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:46:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/268f1bf33d61c34c9ebcb40947f1d262a31ad0b8
Cr-Commit-Position: refs/heads/master@{#375323}

Powered by Google App Engine
This is Rietveld 408576698