Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1696953003: Add a ppapi_unittests_run target. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a ppapi_unittests_run target. This is a subset of https://codereview.chromium.org/1224453003/ (and was reviewed there). Actually running ppapi_unittests on swarming made TSan complain, so only land the isolate file for now. BUG=98637 TBR=raymes Committed: https://crrev.com/475af4b4d3930c626e7e94d3316aa87a2c9a0ca1 Cr-Commit-Position: refs/heads/master@{#375363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
A + ppapi/ppapi_unittests.isolate View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
4 years, 10 months ago (2016-02-13 15:38:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696953003/1
4 years, 10 months ago (2016-02-13 15:38:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-13 16:52:16 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:47:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/475af4b4d3930c626e7e94d3316aa87a2c9a0ca1
Cr-Commit-Position: refs/heads/master@{#375363}

Powered by Google App Engine
This is Rietveld 408576698