Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1696903002: Revert of SkNx refactoring (Closed)

Created:
4 years, 10 months ago by mtklein
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkNx refactoring (patchset #4 id:60001 of https://codereview.chromium.org/1690633003/ ) Reason for revert: Precautionary revert for chromium:586487 Original issue's description: > SkNx refactoring > > - add back Sk4i typedef > - define SSE casts in terms of Sk4i > * uint8 <-> float becomes uint8 <-> int <-> float > * uint16 <-> float becomes uint16 <-> int <-> float > > This has the nice side effect of specializing uint8 <-> int > and uint16 <-> int, which are useful in their own right. > > There are many cast specializations now, some of which call each other. > I have tried to arrange them in some sort of sensible order, subject to > the constraint that those called must precede those who call. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690633003 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/c1eb311f4e98934476f1b2ad5d6de772cf140d60 TBR=herb@google.com,mtklein@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:586487 Committed: https://skia.googlesource.com/skia/+/97120a7ed193b2e081c9503a7c58657e0c6f4920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -55 lines) Patch
M src/core/SkNx.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkNx_sse.h View 2 chunks +38 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mtklein
Created Revert of SkNx refactoring
4 years, 10 months ago (2016-02-12 21:54:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696903002/1
4 years, 10 months ago (2016-02-12 21:54:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/97120a7ed193b2e081c9503a7c58657e0c6f4920
4 years, 10 months ago (2016-02-12 22:19:08 UTC) #6
herb_g
4 years, 10 months ago (2016-02-12 23:19:22 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698