Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 169683006: Reland "Move TextInputController from CppBoundClass to gin::Wrappable." (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, tkent
Visibility:
Public.

Description

Reland "Move TextInputController from CppBoundClass to gin::Wrappable." Also, change the class to use chromium coding style. BUG=297480, 331301 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251773

Patch Set 1 #

Total comments: 2

Patch Set 2 : focusedFrame() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -244 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/TestInterfaces.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/TestInterfaces.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
D content/shell/renderer/test_runner/TextInputController.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/shell/renderer/test_runner/TextInputController.cpp View 1 chunk +0 lines, -193 lines 0 comments Download
A content/shell/renderer/test_runner/text_input_controller.h View 1 chunk +56 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/text_input_controller.cc View 1 1 chunk +252 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
Jochen, could you patch this in?
6 years, 10 months ago (2014-02-18 04:21:19 UTC) #1
jochen (gone - plz use gerrit)
lgtm The original text input controller returns undefined on failure which breaks the entire layout ...
6 years, 10 months ago (2014-02-18 09:13:39 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-18 12:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/169683006/90001
6 years, 10 months ago (2014-02-18 12:50:13 UTC) #4
tfarina
Thanks Jochen! https://codereview.chromium.org/169683006/diff/1/content/shell/renderer/test_runner/text_input_controller.cc File content/shell/renderer/test_runner/text_input_controller.cc (right): https://codereview.chromium.org/169683006/diff/1/content/shell/renderer/test_runner/text_input_controller.cc#newcode225 content/shell/renderer/test_runner/text_input_controller.cc:225: if (!view_->mainFrame()->firstRectForCharacterRange(location, length, rect)) On 2014/02/18 09:13:39, ...
6 years, 10 months ago (2014-02-18 12:50:42 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 16:32:58 UTC) #6
Message was sent while issue was closed.
Change committed as 251773

Powered by Google App Engine
This is Rietveld 408576698