Add shortcuts for zoom, print and saving PDFs.

Add shortcuts for zoom, print and saving PDFs.

BUG=303491
R=arv@chromium.org, koz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252180

[koz (OOO until 15th September), 2014-02-18 05:26:32]

lgtm

[raymes, 2014-02-19 00:22:57]

+arv for OWNERS

[arv (Not doing code reviews), 2014-02-19 02:15:56]

https://codereview.chromium.org/169683005/diff/1/chrome/browser/resources/pdf...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/169683005/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/pdf.js:180: var click =
document.createEvent('MouseEvents');
var click = new MouseEvent('click', {
  bubbles: true,
  cancelable: true
});

...but, can you do $('save-button-link').click();

[raymes, 2014-02-19 03:29:38]

https://codereview.chromium.org/169683005/diff/1/chrome/browser/resources/pdf...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/169683005/diff/1/chrome/browser/resources/pdf...
chrome/browser/resources/pdf/pdf.js:180: var click =
document.createEvent('MouseEvents');
Yep, it works!

[arv (Not doing code reviews), 2014-02-19 21:31:56]

LGTM

[raymes, 2014-02-19 23:49:28]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-02-20 01:20:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/169683005/80001

[commit-bot: I haz the power, 2014-02-20 01:20:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 01:20:13]

Failed to apply patch for chrome/browser/resources/pdf/pdf.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/resources/pdf/pdf.js
  Hunk #1 FAILED at 131.
  Hunk #2 succeeded at 116 (offset -48 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/resources/pdf/pdf.js.rej

Patch:       chrome/browser/resources/pdf/pdf.js
Index: chrome/browser/resources/pdf/pdf.js
diff --git a/chrome/browser/resources/pdf/pdf.js
b/chrome/browser/resources/pdf/pdf.js
index
6cc8421484a0f248ca01fd40d30fedeb6ef68a68..ca9e63b1700a5e12b2edffa563a9e28cf6982247
100644
--- a/chrome/browser/resources/pdf/pdf.js
+++ b/chrome/browser/resources/pdf/pdf.js
@@ -131,7 +131,6 @@ function load() {
   $('save-button-link').href = streamDetails.originalURL;
   $('print-button').addEventListener('click', print);
 
-
   // Setup keyboard event listeners.
   document.onkeydown = function(e) {
     switch (e.keyCode) {
@@ -164,6 +163,29 @@ function load() {
           e.preventDefault();
         }
         return;
+      case 187:  // +/= key.
+      case 107:  // Numpad + key.
+        if (e.ctrlKey)
+          viewport.zoomIn();
+        return;
+      case 189:  // -/_ key.
+      case 109:  // Numpad - key.
+        if (e.ctrlKey)
+          viewport.zoomOut();
+        return;
+      case 83:  // s key.
+        if (e.ctrlKey) {
+          // Simulate a click on the button so that the <a download ...>
+          // attribute is used.
+          $('save-button-link').click();
+        }
+        return;
+      case 80:  // p key.
+        if (e.ctrlKey) {
+          print();
+          e.preventDefault();
+        }
+        return;
     }
   };
 }

[raymes, 2014-02-20 04:42:19]

Committed patchset #2 manually as r252180 (presubmit successful).