Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 169683003: Second attempt at introducing a premonomorphic state in the call (Closed)

Created:
6 years, 10 months ago by kasperl
Modified:
6 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Second attempt at introducing a premonomorphic state in the call target caches. This time we don't go through the premonomorphic state for the Array call target caches to avoid losing information from allocation sites that aren't only used once, but where the resulting array is used heavily. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19457

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -127 lines) Patch
M src/a64/code-stubs-a64.cc View 1 4 chunks +36 lines, -32 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 chunks +41 lines, -31 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +36 lines, -31 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -0 lines 1 comment Download
M src/x64/code-stubs-x64.cc View 1 3 chunks +36 lines, -32 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kasperl
6 years, 10 months ago (2014-02-17 15:23:41 UTC) #1
kasperl
This isn't really ready for committing yet. I've only fixed the ia32 version. We could ...
6 years, 10 months ago (2014-02-17 15:24:41 UTC) #2
mvstanton
I'd say it looks okay, the sunspider fasta test and octane gameboy were affected before, ...
6 years, 10 months ago (2014-02-17 15:35:46 UTC) #3
mvstanton
I'd say it looks okay, the sunspider fasta test and octane gameboy were affected before, ...
6 years, 10 months ago (2014-02-17 15:35:46 UTC) #4
kasperl
Uploaded the missing x64, arm, and a64 ports. This is now ready for a proper ...
6 years, 10 months ago (2014-02-18 08:31:57 UTC) #5
mvstanton
lgtm. I'll land on your behalf. https://codereview.chromium.org/169683003/diff/180001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/169683003/diff/180001/src/runtime.cc#newcode14765 src/runtime.cc:14765: *type_info != isolate->heap()->null_value() ...
6 years, 10 months ago (2014-02-18 15:22:52 UTC) #6
mvstanton
6 years, 10 months ago (2014-02-18 15:34:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r19457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698