Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1696813002: New VS 2015 package with two hot fixes (Closed)

Created:
4 years, 10 months ago by brucedawson
Modified:
4 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jschuh, Sébastien Marchand
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New VS 2015 package with two hot fixes This new VS 2015 package contains updated c2.dll, link.exe, and cl.exe binaries (four variations of each) to fix two bugs. One is a silent bad code-gen bug: https://connect.microsoft.com/VisualStudio/feedback/details/2291638 The other is a bug that causes randomly corrupt object files in debug builds: https://connect.microsoft.com/VisualStudio/feedback/details/1853228 The modification to cl.exe is purely a change to the link timestamp so that goma will detect that this is a new toolchain. Local testing and testing with crrev.com/1680133003 indicate that this is working correctly. The crrev.com/1680133003 compiles failed until goma was updated (good) and all of the tests passed. Committing this change will cause the VS 2015 fyi builders to start using this compiler which will let us gather data on whether the corrupt object file bug is fixed. BUG=440500 Committed: https://crrev.com/8bc2e367ea28a21a1c03333832a7339007d9b9db Cr-Commit-Position: refs/heads/master@{#375221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/vs_toolchain.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
This is another new toolchain that now works correctly with goma. This commit is initially ...
4 years, 10 months ago (2016-02-12 18:20:19 UTC) #2
scottmg
why-not-lgtm
4 years, 10 months ago (2016-02-12 18:31:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696813002/1
4 years, 10 months ago (2016-02-12 18:38:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 19:06:40 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:44:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bc2e367ea28a21a1c03333832a7339007d9b9db
Cr-Commit-Position: refs/heads/master@{#375221}

Powered by Google App Engine
This is Rietveld 408576698