Don't use _inFieldContext tracking.

Don't use _inFieldContext tracking.

For any practicaly purpose it was useless because we casted to
FieldDeclaration anyway to get documentation and isStatic field.

One additional change is that we now create ConstFieldElementImpl only
for non-static final fields. This corresponds to the logic in
ResolverVisitor.visitVariableDeclaration(), which clones initializers
only for final non-static fields.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b61c5c06b14d57042dd63dbade0d45f097bc2868

[Brian Wilkerson, 2016-02-12 18:35:33]

LGTM

[scheglov, 2016-02-12 18:38:42]

Description was changed from

==========
Don't use _inFieldContext tracking.

For any practicaly purpose it was useless because we casted to
FieldDeclaration anyway to get documentation and isStatic field.

One additional change is that we now create ConstFieldElementImpl only
for non-static final fields. This corresponds to the logic in
ResolverVisitor.visitVariableDeclaration(), which clones initializers
only for final non-static fields.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Don't use _inFieldContext tracking.

For any practicaly purpose it was useless because we casted to
FieldDeclaration anyway to get documentation and isStatic field.

One additional change is that we now create ConstFieldElementImpl only
for non-static final fields. This corresponds to the logic in
ResolverVisitor.visitVariableDeclaration(), which clones initializers
only for final non-static fields.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b61c5c06b14d57042dd63dbade0d45f097bc2868
==========

[scheglov, 2016-02-12 18:38:43]

Committed patchset #1 (id:1) manually as
b61c5c06b14d57042dd63dbade0d45f097bc2868 (presubmit successful).