Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1696753002: Change createImageBitmap(Blob) to use ImageDecoder instead of ImageSource (Closed)

Created:
4 years, 10 months ago by xidachen
Modified:
4 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change createImageBitmap(Blob) to use ImageDecoder instead of ImageSource At this moment, createImageBitmap(Blob) uses ImageSource for image decoding, which internally uses DeferredImageDecoder. However, the problem is that we cannot set the AlphaPremultiplied and the GammaAndColorProfileApplied parameters in this case. This CL changes the ImageSource to ImageDecoder where we could explicitly set the premultiplyAlpha and colorProfile parameters. This change will makes it easy later on when we handle premultiplyAlpha =false in the case of createImageBitmap(Blob). Note that this CL doesn't change any behavior, so as long as all layout tests pass, it should be fine. BUG=589132 Committed: https://crrev.com/13834522ca6d7969f80743285dff0e09050b8227 Cr-Commit-Position: refs/heads/master@{#378376}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 2 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
xidachen
PTAL
4 years, 10 months ago (2016-02-12 15:56:32 UTC) #3
xidachen
PTAL.
4 years, 9 months ago (2016-02-29 20:12:26 UTC) #6
Justin Novosad
lgtm
4 years, 9 months ago (2016-02-29 21:14:46 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696753002/20001
4 years, 9 months ago (2016-02-29 21:30:08 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 22:50:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696753002/20001
4 years, 9 months ago (2016-03-01 02:30:30 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 02:37:26 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 02:38:24 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13834522ca6d7969f80743285dff0e09050b8227
Cr-Commit-Position: refs/heads/master@{#378376}

Powered by Google App Engine
This is Rietveld 408576698