Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp

Issue 1696713003: Introduce maxColumnLogicalHeight() and clean up a little. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
index 5f80a52b32a94f8184901ffd5daea61c211e863b..0f58fcefb2f47427dee04a82f6e45825e6635c00 100644
--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
@@ -298,16 +298,8 @@ LayoutUnit MultiColumnFragmentainerGroup::heightAdjustedForRowOffset(LayoutUnit
LayoutUnit MultiColumnFragmentainerGroup::calculateMaxColumnHeight() const
{
- LayoutBlockFlow* multicolBlock = m_columnSet.multiColumnBlockFlow();
- const ComputedStyle& multicolStyle = multicolBlock->styleRef();
LayoutMultiColumnFlowThread* flowThread = m_columnSet.multiColumnFlowThread();
- LayoutUnit availableHeight = flowThread->columnHeightAvailable();
- LayoutUnit maxColumnHeight = availableHeight ? availableHeight : LayoutUnit::max();
- if (!multicolStyle.logicalMaxHeight().isMaxSizeNone()) {
- LayoutUnit logicalMaxHeight = multicolBlock->computeContentLogicalHeight(MaxSize, multicolStyle.logicalMaxHeight(), LayoutUnit(-1));
- if (logicalMaxHeight != -1 && maxColumnHeight > logicalMaxHeight)
- maxColumnHeight = logicalMaxHeight;
- }
+ LayoutUnit maxColumnHeight = flowThread->maxColumnLogicalHeight();
LayoutUnit maxHeight = heightAdjustedForRowOffset(maxColumnHeight);
if (FragmentationContext* enclosingFragmentationContext = flowThread->enclosingFragmentationContext()) {
if (enclosingFragmentationContext->isFragmentainerLogicalHeightKnown()) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698