Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 1696713002: [test runner] Handle missing files gracefully. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test runner] Handle missing files gracefully. This returns a proper test result (failure) when files are missing for setting up the command. Committed: https://crrev.com/061eca59f8d42d403b3cdde21b680624aa3267dc Cr-Commit-Position: refs/heads/master@{#33946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M tools/testrunner/local/execution.py View 3 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael Achenbach
PTAL. This attempts to help debug randomly missing files better: https://chromium-swarm.appspot.com/user/task/2c9681285e622710 I'm afraid, however, that ...
4 years, 10 months ago (2016-02-12 13:24:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696713002/1
4 years, 10 months ago (2016-02-12 13:24:58 UTC) #5
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-12 13:28:03 UTC) #6
tandrii(chromium)
lgtm
4 years, 10 months ago (2016-02-12 13:30:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696713002/1
4 years, 10 months ago (2016-02-12 13:32:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 13:54:07 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 13:54:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/061eca59f8d42d403b3cdde21b680624aa3267dc
Cr-Commit-Position: refs/heads/master@{#33946}

Powered by Google App Engine
This is Rietveld 408576698