Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1696653002: Fix non-Oilpan build following r375129. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-Oilpan build following r375129. R=haraken BUG=543198 Committed: https://crrev.com/e3d8678cb8b52c603ac738410df0cd9f30811fb5 Cr-Commit-Position: refs/heads/master@{#375160}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
assuming there's time....
4 years, 10 months ago (2016-02-12 09:32:41 UTC) #1
haraken
LGTM
4 years, 10 months ago (2016-02-12 09:33:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696653002/20001
4 years, 10 months ago (2016-02-12 09:55:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-12 11:11:25 UTC) #8
nhiroki
Thank you for fixing this!
4 years, 10 months ago (2016-02-15 01:21:36 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:41 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e3d8678cb8b52c603ac738410df0cd9f30811fb5
Cr-Commit-Position: refs/heads/master@{#375160}

Powered by Google App Engine
This is Rietveld 408576698