blimp/client/app/blimp_client_switches.h - Issue 1696563002: Blimp: add support for SSL connections.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/app/blimp_client_switches.h

Issue 1696563002: Blimp: add support for SSL connections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated "running.md" Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines all the command-line switches used by //blimp.	5 // Defines all the command-line switches used by //blimp.

6	6

7 #ifndef BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_	7 #ifndef BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_

8 #define BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_	8 #define BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_

9	9

10 namespace blimp {	10 namespace blimp {

11 namespace switches {	11 namespace switches {

12	12

13 extern const char kBlimpletEndpoint[];	13 // The path to the engine's PEM-encoded X509 certificate.

	14 // If specified, SSL connected Engines must supply this certificate

	15 // for the connection to be valid.

	16 // e.g.:

	17 // --engine-cert-path=/home/blimp/certs/cert.pem

	18 extern const char kEngineCertPath[];

	19

	20 // Specifies the engine scheme, IP-address and port to connect to, e.g.:

	21 // --engine-endpoint="tcp://127.0.0.1:25467". Valid schemes are "ssl",

	22 // "tcp", and "quic".
	Wez 2016/02/26 18:32:08 "quic" is not a valid scheme, surely - we don't ha "quic" is not a valid scheme, surely - we don't have a QUIC transport implemented. Kevin M 2016/02/26 19:57:22 Done. Show quoted text On 2016/02/26 18:32:08, Wez wrote: > "quic" is not a valid scheme, surely - we don't have a QUIC transport > implemented. Done. Wez 2016/03/01 00:23:55 What got done? Looks like it's still here? Show quoted text On 2016/02/26 19:57:22, Kevin M wrote: > On 2016/02/26 18:32:08, Wez wrote: > > "quic" is not a valid scheme, surely - we don't have a QUIC transport > > implemented. > > Done. What got done? Looks like it's still here? Kevin M 2016/03/01 18:23:16 Oops, made most of the change, didn't remove the o Show quoted text On 2016/03/01 00:23:55, Wez wrote: > On 2016/02/26 19:57:22, Kevin M wrote: > > On 2016/02/26 18:32:08, Wez wrote: > > > "quic" is not a valid scheme, surely - we don't have a QUIC transport > > > implemented. > > > > Done. > > What got done? Looks like it's still here? Oops, made most of the change, didn't remove the old stuff. PTAL
	23 // TODO(nyquist): Add support for DNS-lookup. See http://crbug.com/576857.

	24 extern const char kEngineEndpoint[];

14	25

15 } // namespace switches	26 } // namespace switches

16 } // namespace blimp	27 } // namespace blimp

17	28

18 #endif // BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_	29 #endif // BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_

OLD	NEW

« no previous file with comments | « blimp/client/app/android/blimp_jni_registrar.cc ('k') | blimp/client/app/blimp_client_switches.cc » ('j') | blimp/client/session/assignment_source.h » ('J')