Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 169653004: <webview>: Speculative fix (Closed)

Created:
6 years, 10 months ago by Fady Samuel
Modified:
6 years, 10 months ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

<webview>: Speculative fix I'm fairly confident this is the fix to bug 343383. From the stack traces, it appears that during ChildFrameCompositorHelper destruction, DelegatedFrameProvider is destroyed which accesses ChildFrameCompositingHelper::SendReclaimCompositorResourcesToBrowser. That method accesses the BrowserPlugin weak pointer which is destroyed prior to DelegatedFrameProvider's destruction. This change ensures that the weak pointer is the last of the non-primitive members of ChildFrameCompositingHelper to get destroyed. BUG=343383 TBR=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251710

Patch Set 1 #

Patch Set 2 : Fixed compile issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/renderer/child_frame_compositing_helper.h View 2 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/child_frame_compositing_helper.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 10 months ago (2014-02-17 16:46:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/169653004/1
6 years, 10 months ago (2014-02-17 16:47:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 17:08:47 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-17 17:08:48 UTC) #4
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 10 months ago (2014-02-17 18:09:36 UTC) #5
Fady Samuel
The CQ bit was unchecked by fsamuel@chromium.org
6 years, 10 months ago (2014-02-17 18:09:37 UTC) #6
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 10 months ago (2014-02-17 18:09:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/169653004/290001
6 years, 10 months ago (2014-02-17 18:09:44 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 00:38:00 UTC) #9
Message was sent while issue was closed.
Change committed as 251710

Powered by Google App Engine
This is Rietveld 408576698