[MD settings] ManageLanguages layout changes

[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  Settings
rows have been wrapped with .settings-box classes.
Dynamic lists have been wrapped with .list-frame,
.vertical-list and entries are .list-items.

Before and after screenshots: http://imgur.com/a/NQEUK

BUG=512479
Committed: https://crrev.com/b5baf951e4ce37d0f20a7c83922370aeedcbb06c
Cr-Commit-Position: refs/heads/master@{#375299}

[dschuyler, 2016-02-12 00:32:19]

dschuyler@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Dan Beam, 2016-02-12 19:01:28]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-02-12 19:01:29]

hey Dave,

please explain why this is closer to the mocks (uses shared list item style,
...) and include screenshots of before and after.

I think this is a common/reasonable request, especially for solely visual
changes.

[Dan Beam, 2016-02-12 19:01:37]

Description was changed from

==========
[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  The layout is
now closer to the mocks.

BUG=512479
==========

to

==========
[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  The layout is
now closer to the mocks.

BUG=512479
==========

[Dan Beam, 2016-02-12 19:01:37]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[michaelpg, 2016-02-12 22:30:37]

lgtm

[dschuyler, 2016-02-12 23:09:35]

Description was changed from

==========
[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  The layout is
now closer to the mocks.

BUG=512479
==========

to

==========
[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  Settings
rows have been wrapped with .settings-box classes.
Dynamic lists have been wrapped with .list-frame,
.vertical-list and entries are .list-items.

Before and after screenshots: http://imgur.com/a/NQEUK

BUG=512479
==========

[dschuyler, 2016-02-12 23:10:17]

On 2016/02/12 19:01:29, Dan Beam wrote:
> hey Dave,
> 
> please explain why this is closer to the mocks (uses shared list item style,
> ...) and include screenshots of before and after.
> 
> I think this is a common/reasonable request, especially for solely visual
> changes.

I made more specific notes in the CL descriptions and included 
a link to before and after screenshots.

[Dan Beam, 2016-02-12 23:13:51]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-02-12 23:13:53]

lgtm

https://codereview.chromium.org/1696473003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/manage_languages_page.html
(right):

https://codereview.chromium.org/1696473003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/manage_languages_page.html:24:
[[item.language.displayName]]
indent off (2x\s)

[dschuyler, 2016-02-12 23:18:34]

Fixed indent.

https://codereview.chromium.org/1696473003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/manage_languages_page.html
(right):

https://codereview.chromium.org/1696473003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/manage_languages_page.html:24:
[[item.language.displayName]]
On 2016/02/12 23:13:52, Dan Beam wrote:
> indent off (2x\s)

Done.

[dschuyler, 2016-02-13 00:28:02]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-02-13 00:28:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1696473003/#ps20001
(title: "fix indent")

[commit-bot: I haz the power, 2016-02-13 00:28:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696473003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696473003/20001

[commit-bot: I haz the power, 2016-02-13 01:03:05]

Description was changed from

==========
[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  Settings
rows have been wrapped with .settings-box classes.
Dynamic lists have been wrapped with .list-frame,
.vertical-list and entries are .list-items.

Before and after screenshots: http://imgur.com/a/NQEUK

BUG=512479
==========

to

==========
[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  Settings
rows have been wrapped with .settings-box classes.
Dynamic lists have been wrapped with .list-frame,
.vertical-list and entries are .list-items.

Before and after screenshots: http://imgur.com/a/NQEUK

BUG=512479
==========

[commit-bot: I haz the power, 2016-02-13 01:03:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:46:15]

Description was changed from

==========
[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  Settings
rows have been wrapped with .settings-box classes.
Dynamic lists have been wrapped with .list-frame,
.vertical-list and entries are .list-items.

Before and after screenshots: http://imgur.com/a/NQEUK

BUG=512479
==========

to

==========
[MD settings] ManageLanguages layout changes

This CL changes the layout of the ManageLanguages
sub-page part of Language settings.  Settings
rows have been wrapped with .settings-box classes.
Dynamic lists have been wrapped with .list-frame,
.vertical-list and entries are .list-items.

Before and after screenshots: http://imgur.com/a/NQEUK

BUG=512479

Committed: https://crrev.com/b5baf951e4ce37d0f20a7c83922370aeedcbb06c
Cr-Commit-Position: refs/heads/master@{#375299}
==========

[commit-bot: I haz the power, 2016-02-16 22:46:16]

Patchset 2 (id:??) landed as
https://crrev.com/b5baf951e4ce37d0f20a7c83922370aeedcbb06c
Cr-Commit-Position: refs/heads/master@{#375299}