Use internal const-constructor.

Use internal const-constructor.

BUG= http://dartbug.com/25760
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/257272fd42a5ec7e48026cc0157b5be0a1308cab

[floitsch, 2016-02-11 20:51:07]

floitsch@google.com changed reviewers:
+ lrn@google.com

[kevmoo, 2016-02-11 21:19:55]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-02-11 21:19:56]

DBC

https://codereview.chromium.org/1696453002/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/1696453002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:1498: const StreamView(this._stream) :
super._internal();
Please update changelog, too

[Lasse Reichstein Nielsen, 2016-02-11 22:04:49]

LGTM.

Are we sure the users of this const constructor are aware that Stream.empty is a
broadcast stream?

https://codereview.chromium.org/1696453002/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/1696453002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:1498: const StreamView(this._stream) :
super._internal();
Consider making the public parameter name be "stream" instead of "_stream":
  const StreamView(Stream<T> stream): _stream = stream, super._internal();

[floitsch, 2016-02-12 19:29:16]

https://codereview.chromium.org/1696453002/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/1696453002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:1498: const StreamView(this._stream) :
super._internal();
On 2016/02/11 22:04:49, Lasse Reichstein Nielsen wrote:
> Consider making the public parameter name be "stream" instead of "_stream":
>   const StreamView(Stream<T> stream): _stream = stream, super._internal();

Done.

https://codereview.chromium.org/1696453002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:1498: const StreamView(this._stream) :
super._internal();
On 2016/02/11 21:19:56, kevmoo wrote:
> Please update changelog, too

Done.

[floitsch, 2016-02-12 19:29:46]

Description was changed from

==========
Use internal const-constructor.

BUG= http://dartbug.com/25760
==========

to

==========
Use internal const-constructor.

BUG= http://dartbug.com/25760
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/257272fd42a5ec7e48026cc0157b5be0a1308cab
==========

[floitsch, 2016-02-12 19:29:47]

Committed patchset #1 (id:1) manually as
257272fd42a5ec7e48026cc0157b5be0a1308cab (presubmit successful).