Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1696443002: Re-land: Implement ChromeVox Next menus. (Closed)

Created:
4 years, 10 months ago by dmazzoni
Modified:
4 years, 10 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Implement ChromeVox Next menus. Open the menus by pressing Search+Period or by clicking on the icon in the panel. Select an item with the mouse or arrow keys. Everything with a key binding and category appears in the menus by default. Also adds all open tabs to the menus. The feedback when the menu first opens isn't always right, this will be fixed when we get better focus tracking. Previously landed: http://crrev.com//1561773002 and reverted due to msan test failure. This patches spoken_feedback_browsertest to make it more robust. BUG=513717 TBR=dtseng@chromium.org Committed: https://crrev.com/6915ba2647569c75c1cd24099337b881e86a5b17 Cr-Commit-Position: refs/heads/master@{#375043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1114 lines, -213 lines) Patch
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 chunk +30 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json View 12 chunks +66 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/console_tts.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/history.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store.js View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store_test.unitjs View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/composite_tts.js View 1 chunk +13 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 15 chunks +124 lines, -31 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +8 lines, -7 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.css View 1 chunk +206 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html View 3 chunks +8 lines, -103 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 5 chunks +361 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_command.js View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js View 1 chunk +186 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js View 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/tts_interface.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696443002/1
4 years, 10 months ago (2016-02-11 23:35:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 23:47:55 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:39:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6915ba2647569c75c1cd24099337b881e86a5b17
Cr-Commit-Position: refs/heads/master@{#375043}

Powered by Google App Engine
This is Rietveld 408576698