Chromium Code Reviews| Index: net/socket/client_socket_pool_base.h |
| diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h |
| index 8a0a1f3c102512a6945aecd0dc160921262d0274..97ff9183033da64200c218af9b9f0c16ce4a5cda 100644 |
| --- a/net/socket/client_socket_pool_base.h |
| +++ b/net/socket/client_socket_pool_base.h |
| @@ -339,14 +339,19 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper |
| struct IdleSocket { |
| IdleSocket() : socket(NULL) {} |
| + // An idle socket can't be used if it is disconnected or has been used |
| + // before and has received data unexpectedly (hence no longer idle). The |
| + // unread data would be mistaken for the beginning of the next response if |
| + // we were to use the socket for a new request. |
| + // |
| + // Note that a socket that has never been used before (like a preconnected |
| + // socket) with unread data may be reused. This may be, e.g., a SPDY |
|
mmenke
2014/03/26 15:18:32
"may be reused" -> "may be used"
davidben
2014/03/26 16:58:29
Done. Also tweaked the wording slightly.
|
| + // SETTINGS frame. |
| + bool IsUsable() const; |
| + |
| // An idle socket should be removed if it can't be reused, or has been idle |
| // for too long. |now| is the current time value (TimeTicks::Now()). |
| // |timeout| is the length of time to wait before timing out an idle socket. |
| - // |
| - // An idle socket can't be reused if it is disconnected or has received |
| - // data unexpectedly (hence no longer idle). The unread data would be |
| - // mistaken for the beginning of the next response if we were to reuse the |
| - // socket for a new request. |
| bool ShouldCleanup(base::TimeTicks now, base::TimeDelta timeout) const; |
| StreamSocket* socket; |