Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 169643003: Avoid unnecessary style recalc for subtree of focused element. (Closed)

Created:
6 years, 10 months ago by rune
Modified:
6 years, 10 months ago
Reviewers:
eseidel
CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid unnecessary style recalc for subtree of focused element. *** Relanding https://codereview.chromium.org/135183002/ Updating the styles for an element that changes its focus state only needs to force a recalc of the subtree if the subtree contains an element that could match a selector which contains a :focus pseudo class left of child or descendant combinator. At the same time, that :focus pseudo must match the element we are updating focus state for. This is indicated by the return value of Element::childrenAffectedByFocus. This change does a LocalStyleChange when updating the focus state of an element which returns false for childrenAffectedByFocus, and SubtreeStyleChange otherwise. TBR=eseidel BUG=315923 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -4 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/css/AffectedByFocusTest.cpp View 1 chunk +253 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rune
The CQ bit was checked by rune@opera.com
6 years, 10 months ago (2014-02-21 13:38:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/169643003/1
6 years, 10 months ago (2014-02-21 13:38:10 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 14:51:03 UTC) #3
Message was sent while issue was closed.
Change committed as 167598

Powered by Google App Engine
This is Rietveld 408576698