Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/analyzer_experimental/lib/src/services/runtime/coverage/utils.dart

Issue 16964008: Code coverage, something is working now. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for Phil review comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_experimental/lib/src/services/runtime/coverage/utils.dart
diff --git a/pkg/source_maps/lib/src/utils.dart b/pkg/analyzer_experimental/lib/src/services/runtime/coverage/utils.dart
similarity index 63%
copy from pkg/source_maps/lib/src/utils.dart
copy to pkg/analyzer_experimental/lib/src/services/runtime/coverage/utils.dart
index 78f098e70b194e6ad8211d8d1c8cb94b5f88a463..3af22766cf0357acb9e8646a0c92cf14d632285b 100644
--- a/pkg/source_maps/lib/src/utils.dart
+++ b/pkg/analyzer_experimental/lib/src/services/runtime/coverage/utils.dart
@@ -1,22 +1,40 @@
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+library utils;
-/// Utilities that shouldn't be in this package.
-library source_maps.utils;
+
+List<int> getLineOffsets(String text) {
+ var offsets = <int> [0];
+ var wasSR = false;
+ text.codeUnits.asMap().forEach((int i, int codeUnit) {
+ if (codeUnit == 13) {
+ wasSR = true;
+ return;
+ }
+ if (codeUnit == 10) {
+ if (wasSR) {
+ offsets.add(i - 1);
+ } else {
+ offsets.add(i);
+ }
+ }
+ wasSR = false;
+ });
+ return offsets;
+}
/// Find the first entry in a sorted [list] that matches a monotonic predicate.
/// Given a result `n`, that all items before `n` will not match, `n` matches,
/// and all items after `n` match too. The result is -1 when there are no
/// items, 0 when all items match, and list.length when none does.
-// TODO(sigmund): remove this function after dartbug.com/5624 is fixed.
+// TODO(scheglov) remove this function after dartbug.com/5624 is fixed.
int binarySearch(List list, bool matches(item)) {
if (list.length == 0) return -1;
if (matches(list.first)) return 0;
if (!matches(list.last)) return list.length;
-
- int min = 0;
- int max = list.length - 1;
+ var min = 0;
+ var max = list.length - 1;
while (min < max) {
var half = min + ((max - min) ~/ 2);
if (matches(list[half])) {

Powered by Google App Engine
This is Rietveld 408576698