Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1696373005: These files must be in the gypi for GN to remove them... (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gyp/utils.gypi View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein
lgtm
4 years, 10 months ago (2016-02-17 04:33:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696373005/1
4 years, 10 months ago (2016-02-17 04:33:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/32a45f6c96f76e7c57c4ea924dc6b1789859cff7
4 years, 10 months ago (2016-02-17 04:56:16 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 04:56:23 UTC) #8
Message was sent while issue was closed. 
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698