Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1696333002: Don't include field-type.h into objects-inl.h (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
ulan, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't include field-type.h/field-index.h into property.h BUG= Committed: https://crrev.com/036d23ec734aea43e4801b36295c3b3ec86ca66a Cr-Commit-Position: refs/heads/master@{#34035}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -33 lines) Patch
M src/compiler/access-info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-types.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/property.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/property.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-transitions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Toon Verwaest
based on your cl. ptal
4 years, 10 months ago (2016-02-16 10:29:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696333002/1
4 years, 10 months ago (2016-02-16 10:31:23 UTC) #6
Jarin
lgtm. https://codereview.chromium.org/1696333002/diff/1/src/ic/arm/handler-compiler-arm.cc File src/ic/arm/handler-compiler-arm.cc (right): https://codereview.chromium.org/1696333002/diff/1/src/ic/arm/handler-compiler-arm.cc#newcode8 src/ic/arm/handler-compiler-arm.cc:8: #include "src/field-type.h" As discussed offline, that does not ...
4 years, 10 months ago (2016-02-16 10:39:10 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 10:54:49 UTC) #9
ulan
regex lgtm
4 years, 10 months ago (2016-02-16 12:47:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696333002/40001
4 years, 10 months ago (2016-02-16 12:53:19 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/10147) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-02-16 12:54:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696333002/60001
4 years, 10 months ago (2016-02-16 13:01:02 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 10 months ago (2016-02-16 13:28:21 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 13:28:55 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/036d23ec734aea43e4801b36295c3b3ec86ca66a
Cr-Commit-Position: refs/heads/master@{#34035}

Powered by Google App Engine
This is Rietveld 408576698