Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 169633003: ninja: Let TOC code use $lib instead of ${lib}. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com, Ami GONE FROM CHROMIUM
Visibility:
Public.

Description

ninja: Let TOC code use $lib instead of ${lib}. No functionality change, but more consistent with -MF $out.d, and the generated files shrink by a few bytes too. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M pylib/gyp/generator/ninja.py View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
6 years, 10 months ago (2014-02-17 21:45:59 UTC) #1
scottmg
Oh, I always skimmed over those and thought they were shell-expanded, but they're ninja-expanded. TIL ...
6 years, 10 months ago (2014-02-17 22:05:53 UTC) #2
Nico
On 2014/02/17 22:05:53, scottmg wrote: > Oh, I always skimmed over those and thought they ...
6 years, 10 months ago (2014-02-17 23:01:26 UTC) #3
Nico
6 years, 10 months ago (2014-02-17 23:02:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1853 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698